Commit Graph

5546 Commits

Author SHA1 Message Date
Paulo Pinto
ad02c1625f Encode SSO redirect URL as it may contain multiple query parameters
If the returnURL contains multiple query parameters (e.g. http://localhost:3000?foo=bar&bar=baz), the homeserver would fail to correctly parse the URL, and only the first query parameter would be kept.

This is not an issue with the homeserver since the URL cannot be parsed in an unambiguous way, as the resulting URL would be:

https://example.com/_matrix/client/r0/login/sso/redirect?redirectUrl=http://localhost:3000?foo=bar&bar=baz

It's not possible to know whether the bar parameter is part of the "parent" URL, or part of the redirectUrl parameter.

----

To fix this, we now encode the redirectUrl parameter, which results in:

https://example.com/_matrix/client/r0/login/sso/redirect?redirectUrl=http%3A%2F%2Flocalhost%3A3000%2Fparent.html%3Ffoo%3Dbar%26bar%3Dbaz

This URL is correctly parsed by synapse.
2022-10-27 15:42:24 +01:00
R Midhun Suresh
5f57c2d361
Merge pull request #906 from vector-im/playwright
Implement integration tests in Hydrogen using playwright
2022-10-26 11:28:38 +05:30
RMidhunSuresh
a3f70fd29b
Fix formatting 2022-10-25 21:29:28 +05:30
RMidhunSuresh
53c3bf0ab3
Change quotes 2022-10-25 21:20:20 +05:30
RMidhunSuresh
a3a5d278a0
Limit workers to 1 for now 2022-10-25 21:18:56 +05:30
RMidhunSuresh
d810f22237
Remove cypress as dependency 2022-10-25 17:06:39 +05:30
RMidhunSuresh
097d2296e0
Make testing more reliable
- Stop any running containers
- Start dev server from playwright so that we don't keep spawning new
  node instances
2022-10-25 17:02:17 +05:30
Bruno Windels
68707d3963
Merge pull request #907 from vector-im/robertlong/fix-call-expires
Fix isMemberExpired check and typechecking
2022-10-20 11:39:46 +00:00
Robert Long
c0306b45a6 Fix typechecking 2022-10-18 13:43:19 -07:00
Robert Long
e9b8cfbd9e Member should be expired if there's no expires at key 2022-10-18 13:42:01 -07:00
RMidhunSuresh
3ee26e14d7
Convert Cypress --> Playwright 2022-10-18 23:44:58 +05:30
Eric Eastwood
9ad5dd752c
Make no content PL fallback to 0 (#863)
Make no `content` PL fallback to `0`. A valid PL event will have `content` but when you're just stubbing a PL event with an empty object `{}`, it doesn't need to exist and we can just as easily fallback to `0` PL level.

Split off from https://github.com/vector-im/hydrogen-web/pull/653

Changes necessary for https://github.com/matrix-org/matrix-public-archive/pull/57
2022-10-17 15:59:24 -05:00
Eric Eastwood
b4f4636555
Clarify that we no-op because if it's already aborted, that's what we wanted to do anyway (#861)
Split off from https://github.com/vector-im/hydrogen-web/pull/653
2022-10-17 15:56:34 -05:00
Bruno Windels
2416893718
Merge pull request #867 from ibeckermayer/ibeckermayer/ts-conversion-linkify
typescriptifying `linkify` and `regex`
2022-10-17 15:42:15 +00:00
Bruno Windels
b9ed70e453 release sdk 0.1.1 2022-10-14 20:16:56 +02:00
Bruno Windels
154fca5fb6
Merge pull request #901 from vector-im/bwindels/fix-sdk-build
fix sdk build failing on tsc error
2022-10-14 18:15:29 +00:00
Bruno Windels
2d526bc088 fix sdk build failing on tsc error 2022-10-14 20:13:23 +02:00
Bruno Windels
d37965ef91 return promise from _createSessionAfterAuth 2022-10-14 20:08:26 +02:00
Bruno Windels
4d5f202d94
Merge pull request #889 from vector-im/login_with_access_token
Add abiity to setup session immediately after registration without using /login
2022-10-14 08:54:52 +00:00
Bruno Windels
1f8a591cf6 dont need extra log depth 2022-10-14 10:28:42 +02:00
Bruno Windels
f46d2c1bf5 make startWithFinishedRegistration more broadly useful 2022-10-14 10:17:32 +02:00
Bruno Windels
89d031990f
Merge pull request #885 from vector-im/fix-866
Fix sync error
2022-10-14 07:53:56 +00:00
Bruno Windels
d9a4a362d9
Merge pull request #862 from vector-im/madlittlemods/remove-unused-button-styles-that-conflict
Remove unused conflicting generic styles
2022-10-11 16:36:13 +00:00
RMidhunSuresh
dcba6d1500
Split method 2022-10-11 18:05:54 +05:30
RMidhunSuresh
a448c0218d
Fix missing semicolon 2022-10-11 18:01:54 +05:30
RMidhunSuresh
1f764664c9
Expose homeserver from Registration object 2022-10-11 17:58:33 +05:30
RMidhunSuresh
85a9a019c8
Don't inhibit login 2022-10-11 17:58:07 +05:30
R Midhun Suresh
07823c2cd7
Merge pull request #873 from vector-im/madlittlemods/log-errors-to-console
Log errors when mounting views to the console for easier reference
2022-10-11 11:40:35 +05:30
R Midhun Suresh
dc13d1b283
Merge pull request #875 from vector-im/madlittlemods/event-data-attribute-on-announcement-view
Add `data-event-id` to `AnnouncementView` so it appears for state events in the timeline
2022-10-11 11:40:21 +05:30
Bruno Windels
5bf6a75546
Merge pull request #874 from vector-im/madlittlemods/add-more-html-tags
Add `<header>`, `<footer>`, `<style>` HTML tags to template with
2022-10-10 14:26:03 +00:00
Bruno Windels
9d82074cf8
Merge pull request #882 from vector-im/bwindels/calls-expire
Implement `m.expires_ts` for calls
2022-10-10 12:18:25 +00:00
R Midhun Suresh
8ef163353a
Merge pull request #793 from ibeckermayer/ibeckermayer/ts-conversion-observable-map
Typescript conversion for `src/observable/map`
2022-10-10 11:31:25 +05:30
Bruno Windels
7d10bec4ac remove comment not relevant anymore 2022-10-07 10:59:13 +02:00
Bruno Windels
4350537004 cleanup 2022-10-07 10:58:12 +02:00
Bruno Windels
7936863934 remove options on dispose in Member
to ensure callback can't be called anymore, as we don't check
that the member argument is the one currently in GroupCall._members.
2022-10-07 10:07:46 +02:00
Bruno Windels
400df6a4ff ensure removing expired members from call is always logged
also return the log item from logger.log so we can ref it
2022-10-07 10:07:10 +02:00
Bruno Windels
4a36fd96e4 update bundled logviewer 2022-10-06 16:11:16 +02:00
Bruno Windels
a07be730f9 bring member validity period back to 1h 2022-10-06 16:10:50 +02:00
Bruno Windels
a8ac504efd explain when joinedData is set 2022-10-06 16:10:36 +02:00
Bruno Windels
7ae9c3af0d renew at least 10s before own membership expires 2022-10-06 16:00:38 +02:00
Bruno Windels
c87fd4dfed cleanup 2022-10-06 15:59:45 +02:00
Bruno Windels
2ecfb8f139 unify dispose logic in Member 2022-10-06 15:22:15 +02:00
Bruno Windels
7eb8015ace ensure member.dispose is called when removing member
so expiration timer is always stopped
2022-10-06 15:20:05 +02:00
RMidhunSuresh
92ae3a3236
vm may not have created when this is called 2022-10-06 11:41:31 +05:30
Bruno Windels
56ecd39f26 don't assume joinedData is set here
although not entirely sure why it wouldn't be
2022-09-30 17:46:57 +02:00
Bruno Windels
1dddabc038 make removing own membership a bit clearer in the logs 2022-09-30 11:21:26 +02:00
Bruno Windels
b694d13348 can be readonly 2022-09-30 11:20:33 +02:00
Bruno Windels
f2564ed5cc also emit updates for expired, connected members that we didn't kick 2022-09-30 11:20:00 +02:00
Bruno Windels
b5f686b10e also allow clean up while still in Joining state, otherwise we get stuck
in joined state but without joinedData
2022-09-30 11:17:54 +02:00
Bruno Windels
282cba0ff1 call points for PeerCall.delay rely on AbortError actually being thrown
+ fix this in one call point where it wasn't the case
2022-09-30 11:17:07 +02:00