Commit Graph

193 Commits

Author SHA1 Message Date
Bruno Windels
3ff91639c6 log signalingState on negotiationneeded 2023-02-07 20:07:16 +01:00
Bruno Windels
a49c9c17c0
Merge pull request #1017 from vector-im/bwindels/fix-1015
Improve `seq` handling to prevent queue blocking for call signalling messages
2023-02-07 19:50:55 +01:00
Bruno Windels
0fa9d193d9 fix comment typo 2023-02-07 19:42:43 +01:00
Bruno Windels
7f9d64c972 improve logging of arrival of to_device call signalling messages 2023-02-07 19:42:20 +01:00
Bruno Windels
ddb5865ccb actually forgot to dispose peerCall here when replacing 2023-02-07 15:00:56 +01:00
Bruno Windels
02108c69dc remove debug logging 2023-02-07 15:00:45 +01:00
Bruno Windels
f67fb7add6 add unit test for this particular error case 2023-02-07 14:58:57 +01:00
Bruno Windels
e39dd176a4 remove debug logging 2023-02-07 14:58:32 +01:00
Bruno Windels
5f4ad30d03 don't block if it does happen that we have processed a message too early
allow dequeueing if the first seq in the queue is actually lower
than what we already processed. Normally should not happen,
but the bug fixed in the previous commit was aggravated by
this behavior, so be more lenient here.
2023-02-07 14:43:28 +01:00
Bruno Windels
39e9a43a1b be strict about the first seq being 0
otherwise if first 2 messages are delivered in reverse order,
the queue gets blocked
2023-02-07 14:42:44 +01:00
Bruno Windels
cadeae98bc prevent ignored signaling messages from blocking the queue
signaling messages get ignored when they are not for the
currently active call id. In that case we currently don't
advance the lastProcessedSeqNr counter, as we had a problem
before where the counter would be brought out of sync with
seq numbers for other call ids.
However when we've previously processed a signalling message
(e.g. the counter is not undefined) and the first message in the queue
is to be ignored, it will prevent the subsequent messages from being
dequeued as their seq number is more than 1 away from the last
processed seq. This adds an additional counter for ignored seq numbers
that is also used to see if the next message is only 1 away from
the next seq value.

I am adding logging as well here to have a better overview in the future
2023-02-07 14:18:14 +01:00
RMidhunSuresh
9a6d15a72b
Fix unwanted toast appearing when opening client 2023-01-31 16:49:58 +05:30
Bruno Windels
825602a04a dispose local media here when returning early as join takes ownership 2023-01-27 10:12:36 +01:00
Bruno Windels
c8bb5fffb0 don't allow to join a call using a foci 2023-01-27 10:12:22 +01:00
Bruno Windels
365157449e cleanup loops here to not get keys 2023-01-27 10:02:13 +01:00
Bruno Windels
43dea3bfdc detect calls using a foci 2023-01-27 10:01:53 +01:00
Bruno Windels
90ba35da7a listen for members.size changes in CallTile and emit update so memberCount binding updates
also be consistent to not emit updates on call object when changing members map
2023-01-26 14:50:46 +01:00
Bruno Windels
0a9f533421 Merge branch 'bwindels/calls' into bwindels/calltile-ui 2023-01-26 13:27:29 +01:00
Bruno Windels
725757e235 Merge branch 'bwindels/calls' into calls-show-toast 2023-01-26 11:50:52 +01:00
Bruno Windels
043ad98866 element call also terminates prompt calls, so do so too 2023-01-24 23:33:04 +01:00
Bruno Windels
e140a4ba64 element call puts string in terminated, not a boolean 2023-01-24 23:33:04 +01:00
RMidhunSuresh
fa5cb684b0
WIP 2023-01-24 13:51:17 +05:30
Bruno Windels
1df8d31ab5 show call duration in tile 2023-01-23 17:06:33 +01:00
Bruno Windels
3bb889ed9c WIP 2023-01-23 14:53:08 +01:00
Bruno Windels
2bd37970ba each LocalMedia own their streams, so a copy should have their own clone 2023-01-20 17:34:15 +01:00
Bruno Windels
590e9500c1 clone localMedia,so we don't remove audio track from stream sent to peer 2023-01-20 17:33:16 +01:00
Bruno Windels
6645f8f43b remove debug throw 2023-01-20 16:50:15 +01:00
Bruno Windels
b2feaf2b4e fix mixing up params, causing us to call onUpdate on params rather than vm 2023-01-20 16:50:07 +01:00
Bruno Windels
920fedae5e merge master into bwindels/calls 2023-01-20 16:24:38 +01:00
Bruno Windels
2408850678 emit change before logging 2023-01-19 11:33:21 +01:00
Bruno Windels
3842f450dd ensure errors caught by boundary are logged in calls code 2023-01-19 11:30:23 +01:00
Bruno Windels
e33209b747 start logging in view model and pass it on to model methods (calls+room) 2023-01-19 09:54:02 +01:00
Bruno Windels
1e4180a71f add error boundary to GroupCall 2023-01-19 09:48:59 +01:00
Bruno Windels
7f9edbb742 this can be private 2023-01-19 09:46:19 +01:00
Bruno Windels
b1687d7115 introduce error boundary in call member 2023-01-19 09:46:19 +01:00
RMidhunSuresh
1cd6540476
Don't use getter here 2023-01-17 14:32:02 +05:30
RMidhunSuresh
ce5c5779bd
Set mute -> mute 2023-01-17 14:24:20 +05:30
RMidhunSuresh
c064336e35
Create localPreviewMedia in GroupCall.setMedia 2023-01-16 15:28:50 +05:30
RMidhunSuresh
f6c94ecc5a
WIP 2023-01-16 13:41:47 +05:30
Bruno Windels
cb0f803276 make this code a bit clearer 2023-01-06 12:05:34 +01:00
Bruno Windels
fcb4f2a62d fix microphone audio being played back through local video preview 2023-01-06 12:05:11 +01:00
Bruno Windels
e26eb30b82 rename m.expires_ts to expires_ts to be compatible with MSC/Element 2023-01-05 15:47:01 +01:00
Robert Long
e9b8cfbd9e Member should be expired if there's no expires at key 2022-10-18 13:42:01 -07:00
Bruno Windels
7d10bec4ac remove comment not relevant anymore 2022-10-07 10:59:13 +02:00
Bruno Windels
4350537004 cleanup 2022-10-07 10:58:12 +02:00
Bruno Windels
7936863934 remove options on dispose in Member
to ensure callback can't be called anymore, as we don't check
that the member argument is the one currently in GroupCall._members.
2022-10-07 10:07:46 +02:00
Bruno Windels
400df6a4ff ensure removing expired members from call is always logged
also return the log item from logger.log so we can ref it
2022-10-07 10:07:10 +02:00
Bruno Windels
a07be730f9 bring member validity period back to 1h 2022-10-06 16:10:50 +02:00
Bruno Windels
a8ac504efd explain when joinedData is set 2022-10-06 16:10:36 +02:00
Bruno Windels
7ae9c3af0d renew at least 10s before own membership expires 2022-10-06 16:00:38 +02:00