RMidhunSuresh
b5fd3656a7
Fix code breaking on dev server
2022-06-12 16:53:25 +05:30
R Midhun Suresh
acffd15002
Add comment
...
Co-authored-by: Bruno Windels <274386+bwindels@users.noreply.github.com>
2022-06-12 16:52:21 +05:30
R Midhun Suresh
989ecd785a
Lowercase string
...
Co-authored-by: Bruno Windels <274386+bwindels@users.noreply.github.com>
2022-06-12 16:51:58 +05:30
RMidhunSuresh
9a5a002293
Remove test-variant
2022-06-08 13:35:58 +05:30
Eric Eastwood
2cfd08e500
Remove debug logging
2022-06-07 23:47:38 -05:00
Eric Eastwood
2b4a7f05a6
Fix Vite not being able analyze dynamic CSS styles import in dev
...
Fix:
```
$ yarn start
[vite] warning:
@theme/default
1 | import "C:\Users\MLM\Documents\GitHub\element\hydrogen-web\src\platform\web\ui\css\themes\element\theme.css";import "@theme/element/light/variables.css"
| ^
The above dynamic import cannot be analyzed by vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.
Plugin: vite:import-analysis
File: @theme/default
```
And in the browser, it results in none of the styles loading because of the following error:
```
Uncaught SyntaxError: Invalid Unicode escape sequence (at default:formatted:1:163)
```
---
Before:
```
import { injectQuery as __vite__injectQuery } from "/@vite/client";import "__vite__injectQuery(C:\Users\MLM\Documents\GitHub\element\hydrogen-web\src\platform\web\ui\css\themes\element\theme.css, 'import')";import "/@id/__x00__@theme/element/light/variables.css"
```
After:
```
import "/ui/css/themes/element/theme.css";import "/@id/__x00__@theme/element/light/variables.css"
```
2022-06-07 23:41:45 -05:00
RMidhunSuresh
d31f127982
Add explaining comment
2022-06-07 13:28:56 +05:30
RMidhunSuresh
d08cfe3a29
Add more logging
2022-06-07 11:57:57 +05:30
RMidhunSuresh
51a837d459
Remove unuseed import
2022-06-06 17:26:39 +05:30
RMidhunSuresh
2f0f7143b5
Simplify code
2022-06-06 17:20:36 +05:30
RMidhunSuresh
0dac00f327
themeVariant is optional
2022-06-06 17:20:16 +05:30
RMidhunSuresh
a639fc5467
Rever to sensisble defaults
2022-06-06 12:20:06 +05:30
RMidhunSuresh
258a604cc6
Don't make defaultTheme compulsory
2022-06-06 12:19:48 +05:30
RMidhunSuresh
a2cbac9e0c
Move code into method
2022-06-06 11:53:13 +05:30
RMidhunSuresh
71c3fb39a2
store theme-name and variant in settings
2022-06-05 20:52:47 +05:30
RMidhunSuresh
43244fa026
Add explaining comment
2022-06-05 20:52:47 +05:30
RMidhunSuresh
9e88bc3098
Fix bugs
2022-06-05 20:52:47 +05:30
RMidhunSuresh
b74f4b612b
Change UI
2022-06-05 20:52:47 +05:30
RMidhunSuresh
8de91291dd
Add more methods to ThemeLoader
2022-06-05 20:52:47 +05:30
RMidhunSuresh
dc2d1ce700
Remove id
2022-06-05 20:52:47 +05:30
RMidhunSuresh
12a8e94243
Move code into ThemeLoader
2022-06-05 20:52:47 +05:30
RMidhunSuresh
9e79b632a8
Extract variable
2022-06-05 20:52:47 +05:30
RMidhunSuresh
efb1a67470
Make method name a verb
2022-06-05 20:52:47 +05:30
RMidhunSuresh
e3235ea3eb
Rename themeName --> themeId
2022-06-05 20:52:47 +05:30
RMidhunSuresh
46d2792dac
Modify comment
2022-06-05 20:52:47 +05:30
RMidhunSuresh
8ad0b8a726
rename themeName --> variantName
2022-06-05 20:52:47 +05:30
RMidhunSuresh
e8e4c33bae
Rephrase comment
2022-06-05 20:52:47 +05:30
RMidhunSuresh
cb03e97e78
Use default theme intially
2022-06-05 20:52:47 +05:30
RMidhunSuresh
f6cec938a7
Add default theme to mapping
2022-06-05 20:52:47 +05:30
RMidhunSuresh
bbec2effe5
Add typing
2022-06-05 20:52:47 +05:30
RMidhunSuresh
d4084da299
Extract code into function
2022-06-05 20:52:47 +05:30
RMidhunSuresh
1f00c8f635
Add a temporary theme to test this PR
2022-06-05 20:52:47 +05:30
RMidhunSuresh
0b98473e85
Render a radio button for default variants
2022-06-05 20:52:47 +05:30
RMidhunSuresh
3afbe1148e
Use the new built-asset format in ThemeLoader
2022-06-05 20:52:47 +05:30
RMidhunSuresh
809c522571
Change the format of built-asset
2022-06-05 20:52:47 +05:30
RMidhunSuresh
4474458f4b
getActiveTheme should never return undefined
...
Instead it should throw an error.
This is useful for when we do setTheme(await getActiveTheme()) because
setTheme expects a string.
2022-06-05 20:52:47 +05:30
Eric Eastwood
9d8a578dce
Better comment
2022-05-31 15:35:48 -05:00
Eric Eastwood
38c3774869
Import assets from the assets/ directory
...
> Will be easier towards the future when adding more assets. Probably best to keep style.css for now for backwards compat though.
>
> *-- https://github.com/vector-im/hydrogen-web/pull/693#discussion_r853844282 *
2022-05-31 15:30:56 -05:00
Bruno Windels
8b2299852e
Merge pull request #744 from vector-im/bwindels/fix-tracker-changed-key-check
...
Fix: device with changed key not being properly ignored
2022-05-31 13:51:17 +02:00
Bruno Windels
c62c8da10b
fix changed key not being ignored
2022-05-31 13:39:35 +02:00
Bruno Windels
bc51644868
reassignment is not used later on, remove
2022-05-31 13:39:23 +02:00
Bruno Windels
3d3d590334
add failing test for device with changed key being returned
2022-05-31 13:39:05 +02:00
Bruno Windels
11d7535c23
add some basic tests (with mock utils) for DeviceTracker
2022-05-31 13:38:34 +02:00
Bruno Windels
a49d7eae5d
Merge pull request #693 from vector-im/madlittlemods/686-682-local-friendly-development-and-commonjs
...
Make the SDK friendly to locally link and develop on
2022-05-30 14:45:16 +02:00
Bruno Windels
1b2a6b5d0e
Merge branch 'master' into madlittlemods/686-682-local-friendly-development-and-commonjs
2022-05-30 14:15:19 +02:00
RMidhunSuresh
ba647d012d
Fix type in observeNavigation
2022-05-29 20:38:14 +05:30
RMidhunSuresh
fc873757d8
WIP
2022-05-27 22:42:21 +05:30
RMidhunSuresh
ec1cc89cf9
Make URLRouter in options conditional on generic
...
URLRouter can be passed in option to vm only if the SegmentType used
contains session.
ViewModel.urlCreator returns undefined when used with a SegmentType that
lacks session.
2022-05-27 22:42:21 +05:30
RMidhunSuresh
a336623f3a
Generic parameter should extend object
2022-05-27 22:42:21 +05:30
RMidhunSuresh
9300347e9b
Give defaultt type
2022-05-27 22:42:21 +05:30