fix lint warnings

This commit is contained in:
Bruno Windels 2021-08-24 15:31:18 +02:00
parent 3d4f69d048
commit e105bc4237
12 changed files with 17 additions and 18 deletions

View File

@ -219,7 +219,7 @@ export class TilesCollection extends BaseObservableList {
} }
} }
onMove(fromIdx, toIdx, value) { onMove(/*fromIdx, toIdx, value*/) {
// this ... cannot happen in the timeline? // this ... cannot happen in the timeline?
// perhaps we can use this event to support a local echo (in a different fragment) // perhaps we can use this event to support a local echo (in a different fragment)
// to be moved to the key of the remote echo, so we don't loose state ... ? // to be moved to the key of the remote echo, so we don't loose state ... ?

View File

@ -59,7 +59,7 @@ export class TimelineViewModel extends ViewModel {
} }
} }
unloadAtTop(tileAmount) { unloadAtTop(/*tileAmount*/) {
// get lowerSortKey for tile at index tileAmount - 1 // get lowerSortKey for tile at index tileAmount - 1
// tell timeline to unload till there (included given key) // tell timeline to unload till there (included given key)
} }
@ -68,7 +68,7 @@ export class TimelineViewModel extends ViewModel {
} }
unloadAtBottom(tileAmount) { unloadAtBottom(/*tileAmount*/) {
// get upperSortKey for tile at index tiles.length - tileAmount // get upperSortKey for tile at index tiles.length - tileAmount
// tell timeline to unload till there (included given key) // tell timeline to unload till there (included given key)
} }

View File

@ -101,7 +101,7 @@ export class SimpleTile extends ViewModel {
// return whether the tile should be removed // return whether the tile should be removed
// as SimpleTile only has one entry, the tile should be removed // as SimpleTile only has one entry, the tile should be removed
removeEntry(entry) { removeEntry(/*entry*/) {
return true; return true;
} }
@ -110,12 +110,12 @@ export class SimpleTile extends ViewModel {
return false; return false;
} }
// let item know it has a new sibling // let item know it has a new sibling
updatePreviousSibling(prev) { updatePreviousSibling(/*prev*/) {
} }
// let item know it has a new sibling // let item know it has a new sibling
updateNextSibling(next) { updateNextSibling(/*next*/) {
} }

View File

@ -147,7 +147,7 @@ export class RelationWriter {
return true; return true;
} }
_aggregateAnnotation(annotationEvent, targetStorageEntry, log) { _aggregateAnnotation(annotationEvent, targetStorageEntry/*, log*/) {
// TODO: do we want to verify it is a m.reaction event somehow? // TODO: do we want to verify it is a m.reaction event somehow?
const relation = getRelation(annotationEvent); const relation = getRelation(annotationEvent);
if (!relation) { if (!relation) {

View File

@ -42,7 +42,7 @@ export class MappedMap extends BaseObservableMap {
this.emitAdd(key, mappedValue); this.emitAdd(key, mappedValue);
} }
onRemove(key, _value) { onRemove(key/*, _value*/) {
const mappedValue = this._mappedValues.get(key); const mappedValue = this._mappedValues.get(key);
if (this._mappedValues.delete(key)) { if (this._mappedValues.delete(key)) {
this.emitRemove(key, mappedValue); this.emitRemove(key, mappedValue);

View File

@ -156,7 +156,7 @@ export function tests() {
assert.equal(key, 1); assert.equal(key, 1);
assert.deepEqual(value, {value: 5}); assert.deepEqual(value, {value: 5});
}, },
onUpdate(key, value, params) { onUpdate(key, value/*, params*/) {
update_fired += 1; update_fired += 1;
assert.equal(key, 1); assert.equal(key, 1);
assert.deepEqual(value, {value: 7}); assert.deepEqual(value, {value: 7});

View File

@ -221,7 +221,7 @@ export class Platform {
if (mimeType) { if (mimeType) {
input.setAttribute("accept", mimeType); input.setAttribute("accept", mimeType);
} }
const promise = new Promise((resolve, reject) => { const promise = new Promise(resolve => {
const checkFile = () => { const checkFile = () => {
input.removeEventListener("change", checkFile, true); input.removeEventListener("change", checkFile, true);
const file = input.files[0]; const file = input.files[0];

View File

@ -121,7 +121,7 @@ export class ListView {
this.onListChanged(); this.onListChanged();
} }
onRemove(idx, _value) { onRemove(idx/*, _value*/) {
this.onBeforeListChanged(); this.onBeforeListChanged();
const [child] = this._childInstances.splice(idx, 1); const [child] = this._childInstances.splice(idx, 1);
child.root().remove(); child.root().remove();
@ -129,7 +129,7 @@ export class ListView {
this.onListChanged(); this.onListChanged();
} }
onMove(fromIdx, toIdx, value) { onMove(fromIdx, toIdx/*, value*/) {
this.onBeforeListChanged(); this.onBeforeListChanged();
const [child] = this._childInstances.splice(fromIdx, 1); const [child] = this._childInstances.splice(fromIdx, 1);
this._childInstances.splice(toIdx, 0, child); this._childInstances.splice(toIdx, 0, child);

View File

@ -17,7 +17,6 @@ limitations under the License.
import {TemplateView} from "../../general/TemplateView.js"; import {TemplateView} from "../../general/TemplateView.js";
import {Popup} from "../../general/Popup.js"; import {Popup} from "../../general/Popup.js";
import {Menu} from "../../general/Menu.js"; import {Menu} from "../../general/Menu.js";
import {TextMessageView} from "./timeline/TextMessageView.js";
import {viewClassForEntry} from "./TimelineList.js" import {viewClassForEntry} from "./TimelineList.js"
export class MessageComposer extends TemplateView { export class MessageComposer extends TemplateView {

View File

@ -17,7 +17,7 @@ limitations under the License.
import {TemplateView} from "../../general/TemplateView.js"; import {TemplateView} from "../../general/TemplateView.js";
export class RoomArchivedView extends TemplateView { export class RoomArchivedView extends TemplateView {
render(t, vm) { render(t) {
return t.div({className: "RoomArchivedView"}, t.h3(vm => vm.description)); return t.div({className: "RoomArchivedView"}, t.h3(vm => vm.description));
} }
} }

View File

@ -97,7 +97,7 @@ const formatFunction = {
link: linkPart => tag.a({href: linkPart.url, className: "link", target: "_blank", rel: "noopener" }, renderParts(linkPart.inlines)), link: linkPart => tag.a({href: linkPart.url, className: "link", target: "_blank", rel: "noopener" }, renderParts(linkPart.inlines)),
pill: renderPill, pill: renderPill,
format: formatPart => tag[formatPart.format](renderParts(formatPart.children)), format: formatPart => tag[formatPart.format](renderParts(formatPart.children)),
rule: rulePart => tag.hr(), rule: () => tag.hr(),
list: renderList, list: renderList,
image: renderImage, image: renderImage,
newline: () => tag.br() newline: () => tag.br()

View File

@ -55,9 +55,9 @@ export class EventEmitter {
} }
} }
onFirstSubscriptionAdded(name) {} onFirstSubscriptionAdded(/* name */) {}
onLastSubscriptionRemoved(name) {} onLastSubscriptionRemoved(/* name */) {}
} }
export function tests() { export function tests() {