mirrors/vector-im-hydrogen-web
1
0
Fork 0
mirror of https://github.com/vector-im/hydrogen-web.git synced 2024-12-23 03:25:12 +01:00
Code Issues Projects Releases Wiki Activity

swallow errors in errorCallback in ErrorBoundary

Browse Source 
nothing should be able to make ErrorBoundary.try throw
This commit is contained in:
Bruno Windels 2023-01-19 11:37:39 +01:00
parent 2408850678
commit daad19c060
1 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/utils/ErrorBoundary.ts
View File

@ -32,18 +32,26 @@ export class ErrorBoundary {
if (result instanceof Promise) { if (result instanceof Promise) {
result = result.catch(err => { result = result.catch(err => {
this._error = err; this._error = err;
this.errorCallback(err); this.reportError(err);
return errorValue; return errorValue;
}); });
} }
return result; return result;
} catch (err) { } catch (err) {
this._error = err; this._error = err;
this.errorCallback(err); this.reportError(err);
return errorValue; return errorValue;
} }
} }
private reportError(err: Error) {
try {
this.errorCallback(err);
} catch (err) {
console.error("error in ErrorBoundary callback", err);
}
}
get error(): Error | undefined { get error(): Error | undefined {
return this._error; return this._error;
} }
@ -77,6 +85,15 @@ export function tests() {
}, 0); }, 0);
assert(emitted); assert(emitted);
assert.strictEqual(result, 0); assert.strictEqual(result, 0);
},
"exception in error callback is swallowed": async assert => {
let emitted = false;
const boundary = new ErrorBoundary(() => { throw new Error("bug in errorCallback"); });
assert.doesNotThrow(() => {
boundary.try(() => {
throw new Error("fail!");
});
});
} }
} }
} }