don't reimplement removing an item from the list

This commit is contained in:
Bruno Windels 2020-10-27 16:26:45 +01:00
parent 97c3a4b8f3
commit d55f38a9e9

View File

@ -147,17 +147,15 @@ export class ListView {
recreateItem(index, value) { recreateItem(index, value) {
if (this._childInstances) { if (this._childInstances) {
const child = this._childCreator(value); const child = this._childCreator(value);
let oldChild; if (!child) {
if (child) { this.onRemove(index, value);
oldChild = this._childInstances.splice(index, 1, child)[0];
this._root.replaceChild(child.mount(this._mountArgs), oldChild.root());
} else { } else {
oldChild = this._childInstances.splice(index, 1)[0]; const [oldChild] = this._childInstances.splice(index, 1, child);
oldChild.root().remove(); this._root.replaceChild(child.mount(this._mountArgs), oldChild.root());
}
oldChild.unmount(); oldChild.unmount();
} }
} }
}
onBeforeListChanged() {} onBeforeListChanged() {}
onListChanged() {} onListChanged() {}