From c1161e5332cc64ab3c407f27495149d84c8da272 Mon Sep 17 00:00:00 2001 From: Isaiah Becker-Mayer Date: Sun, 14 Aug 2022 11:27:25 -0700 Subject: [PATCH] typescript-ifying CompleteSSOLoginViewModel --- ...wModel.js => CompleteSSOLoginViewModel.ts} | 27 ++++++++++++++----- src/domain/login/LoginViewModel.ts | 4 +-- 2 files changed, 22 insertions(+), 9 deletions(-) rename src/domain/login/{CompleteSSOLoginViewModel.js => CompleteSSOLoginViewModel.ts} (72%) diff --git a/src/domain/login/CompleteSSOLoginViewModel.js b/src/domain/login/CompleteSSOLoginViewModel.ts similarity index 72% rename from src/domain/login/CompleteSSOLoginViewModel.js rename to src/domain/login/CompleteSSOLoginViewModel.ts index d41d53ec..b7be4642 100644 --- a/src/domain/login/CompleteSSOLoginViewModel.js +++ b/src/domain/login/CompleteSSOLoginViewModel.ts @@ -14,11 +14,24 @@ See the License for the specific language governing permissions and limitations under the License. */ -import {ViewModel} from "../ViewModel"; +import {Options as BaseOptions, ViewModel} from "../ViewModel"; import {LoginFailure} from "../../matrix/Client.js"; +import type {TokenLoginMethod} from "../../matrix/login"; +import { Client } from "../../matrix/Client.js"; + +type Options = { + client: Client; + attemptLogin: (loginMethod: TokenLoginMethod) => Promise; + loginToken: string; +} & BaseOptions export class CompleteSSOLoginViewModel extends ViewModel { - constructor(options) { + private _loginToken: string; + private _client: Client; + private _attemptLogin: (loginMethod: TokenLoginMethod) => Promise; + private _errorMessage = ""; + + constructor(options: Options) { super(options); const { loginToken, @@ -29,22 +42,22 @@ export class CompleteSSOLoginViewModel extends ViewModel { this._client = client; this._attemptLogin = attemptLogin; this._errorMessage = ""; - this.performSSOLoginCompletion(); + void this.performSSOLoginCompletion(); } - get errorMessage() { return this._errorMessage; } + get errorMessage(): string { return this._errorMessage; } - _showError(message) { + _showError(message: string): void { this._errorMessage = message; this.emitChange("errorMessage"); } - async performSSOLoginCompletion() { + async performSSOLoginCompletion(): Promise { if (!this._loginToken) { return; } const homeserver = await this.platform.settingsStorage.getString("sso_ongoing_login_homeserver"); - let loginOptions; + let loginOptions: { token?: (loginToken: string) => TokenLoginMethod; }; try { loginOptions = await this._client.queryLogin(homeserver).result; } diff --git a/src/domain/login/LoginViewModel.ts b/src/domain/login/LoginViewModel.ts index 43f0334a..75d57880 100644 --- a/src/domain/login/LoginViewModel.ts +++ b/src/domain/login/LoginViewModel.ts @@ -18,7 +18,7 @@ import {Client} from "../../matrix/Client.js"; import {Options as BaseOptions, ViewModel} from "../ViewModel"; import {PasswordLoginViewModel} from "./PasswordLoginViewModel"; import {StartSSOLoginViewModel} from "./StartSSOLoginViewModel"; -import {CompleteSSOLoginViewModel} from "./CompleteSSOLoginViewModel.js"; +import {CompleteSSOLoginViewModel} from "./CompleteSSOLoginViewModel"; import {LoadStatus} from "../../matrix/Client.js"; import {SessionLoadViewModel} from "../SessionLoadViewModel.js"; import {SegmentType} from "../navigation/index"; @@ -68,7 +68,7 @@ export class LoginViewModel extends ViewModel { return this._startSSOLoginViewModel; } - get completeSSOLoginViewModel(): CompleteSSOLoginViewModel { + get completeSSOLoginViewModel(): CompleteSSOLoginViewModel | undefined { return this._completeSSOLoginViewModel; }