add clarification why this doesn't need to also check member changes

This commit is contained in:
Bruno Windels 2021-03-05 17:04:18 +01:00
parent f4a7782298
commit b37a586094

View File

@ -266,6 +266,9 @@ export class Room extends EventEmitter {
// fetch new members while we have txn open, // fetch new members while we have txn open,
// but don't make any in-memory changes yet // but don't make any in-memory changes yet
let heroChanges; let heroChanges;
// if any hero changes their display name, the summary in the room response
// is also updated, which will trigger a RoomSummary update
// and make summaryChanges non-falsy here
if (summaryChanges?.needsHeroes) { if (summaryChanges?.needsHeroes) {
// room name disappeared, open heroes // room name disappeared, open heroes
if (!this._heroes) { if (!this._heroes) {