Merge pull request #362 from vector-im/bwindels/lintfixesandci

Fix/disable lint errors and enable in CI

.eslintignore

@@ -0,0 +1 @@
+src/matrix/storage/memory

.eslintrc.js

@@ -10,6 +10,8 @@ module.exports = {
     },
     "rules": {
         "no-console": "off",
-        "no-empty": "off"
+        "no-empty": "off",
+        "no-prototype-builtins": "off",
+        "no-unused-vars": "warn",
     }
 };

.github/workflows/codechecks.js.yml

@@ -1,7 +1,7 @@
 # This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
 # For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
 
-name: Unit tests
+name: Code checks
 
 on:
   push:
@@ -19,10 +19,15 @@ jobs:
         node-version: [14.x]
 
     steps:
-    - uses: actions/checkout@v2
+    - name: Checkout project source
-    - name: Run unit tests
+      uses: actions/checkout@v2
+    - name: Install tools
       uses: actions/setup-node@v2
       with:
         node-version: ${{ matrix.node-version }}
-    - run: npm install --also=dev
+    - name: Install project dependencies
-    - run: npm test
+      run: npm install --also=dev
+    - name: Unit tests
+      run: npm test
+    - name: Lint
+      run: npm run lint-ci

.gitignore

@@ -7,3 +7,4 @@ bundle.js
 target
 lib
 *.tar.gz
+.eslintcache

package.json

@@ -7,7 +7,8 @@
     "doc": "doc"
   },
   "scripts": {
-    "lint": "eslint src/",
+    "lint": "eslint --cache src/",
+    "lint-ci": "eslint src/",
     "test": "impunity --entry-point src/main.js --force-esm-dirs lib/ src/",
     "start": "node scripts/serve-local.js",
     "build": "node --experimental-modules scripts/build.mjs",

src/domain/navigation/URLRouter.js

@@ -86,7 +86,7 @@ export class URLRouter {
     tryRestoreLastUrl() {
         const lastNavPath = this._urlAsNavPath(this._history.getLastUrl() || "");
         if (lastNavPath.segments.length !== 0) {
-            this._applyNavPathToNavigation(navPath);
+            this._applyNavPathToNavigation(lastNavPath);
             return true;
         }
         return false;