From b29287c47ee60323b5414bdf60cf696100ed5f41 Mon Sep 17 00:00:00 2001
From: RMidhunSuresh <hi@midhun.dev>
Date: Sun, 17 Jul 2022 22:29:36 +0530
Subject: [PATCH] await in loop --> Promise.all()

---
 src/platform/web/ThemeBuilder.ts | 2 +-
 src/platform/web/ThemeLoader.ts  | 9 ++++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/platform/web/ThemeBuilder.ts b/src/platform/web/ThemeBuilder.ts
index c87e68fb..85d1e336 100644
--- a/src/platform/web/ThemeBuilder.ts
+++ b/src/platform/web/ThemeBuilder.ts
@@ -35,7 +35,7 @@ export class ThemeBuilder {
     }
 
     async populateDerivedTheme(manifest: ThemeManifest, log: ILogItem): Promise<void> {
-        await log.wrap("ThemeBuilder.populateThemeMap", async (l) => {
+        await log.wrap("ThemeBuilder.populateThemeMap", async () => {
             const {manifest: baseManifest, location} = this._idToManifest.get(manifest.extends!)!;
             const {cssLocation, derivedVariables, icons} = this._getSourceData(baseManifest, location, log);
             const themeName = manifest.name;
diff --git a/src/platform/web/ThemeLoader.ts b/src/platform/web/ThemeLoader.ts
index da5f9658..b899ab5e 100644
--- a/src/platform/web/ThemeLoader.ts
+++ b/src/platform/web/ThemeLoader.ts
@@ -60,11 +60,13 @@ export class ThemeLoader {
             );
             results.forEach(({ body }, i) => idToManifest.set(body.id, { manifest: body, location: manifestLocations[i] }));
             this._themeBuilder = new ThemeBuilder(this._platform, idToManifest, this.preferredColorScheme);
+            const runtimeThemePromises: Promise<void>[] = [];
             for (let i = 0; i < results.length; ++i) {
                 const { body } = results[i];
                 try {
                     if (body.extends) {
-                        await this._themeBuilder.populateDerivedTheme(body, log);
+                        const promise = this._themeBuilder.populateDerivedTheme(body, log);
+                        runtimeThemePromises.push(promise);
                     }
                     else {
                         this._populateThemeMap(body, manifestLocations[i], log);
@@ -74,8 +76,9 @@ export class ThemeLoader {
                     console.error(e);
                 }
             }
+            await Promise.all(runtimeThemePromises);
             Object.assign(this._themeMapping, this._themeBuilder.themeMapping);
-            //Add the default-theme as an additional option to the mapping
+            // Add the default-theme as an additional option to the mapping
             const defaultThemeId = this.getDefaultTheme();
             if (defaultThemeId) {
                 const themeDetails = this._findThemeDetailsFromId(defaultThemeId);
@@ -94,7 +97,7 @@ export class ThemeLoader {
     }
 
     private _populateThemeMap(manifest: ThemeManifest, manifestLocation: string, log: ILogItem) {
-        log.wrap("populateThemeMap", (l) => {
+        log.wrap("populateThemeMap", () => {
             /*
             After build has finished, the source section of each theme manifest
             contains `built-assets` which is a mapping from the theme-id to