From b03b296391dd1d7520607937edecc43eaf63d7cd Mon Sep 17 00:00:00 2001 From: Bruno Windels <274386+bwindels@users.noreply.github.com> Date: Wed, 27 Apr 2022 19:41:25 +0200 Subject: [PATCH] comments, todo housekeeping --- src/matrix/calls/PeerCall.ts | 1 + src/matrix/calls/TODO.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/matrix/calls/PeerCall.ts b/src/matrix/calls/PeerCall.ts index 15331ab5..e5e70a46 100644 --- a/src/matrix/calls/PeerCall.ts +++ b/src/matrix/calls/PeerCall.ts @@ -184,6 +184,7 @@ export class PeerCall implements IDisposable { } // after adding the local tracks, and wait for handleNegotiation to be called, // or invite glare where we give up our invite and answer instead + // TODO: we don't actually use this await this.waitForState([CallState.InviteSent, CallState.CreateAnswer]); }); } diff --git a/src/matrix/calls/TODO.md b/src/matrix/calls/TODO.md index a7f4e82c..91840af7 100644 --- a/src/matrix/calls/TODO.md +++ b/src/matrix/calls/TODO.md @@ -14,7 +14,7 @@ - implement muting tracks with m.call.sdp_stream_metadata_changed - implement renegotiation - making logging better - - finish session id support + - DONE: finish session id support - call peers are essentially identified by (userid, deviceid, sessionid). If see a new session id, we first disconnect from the current member so we're ready to connect with a clean slate again (in a member event, also in to_device? no harm I suppose, given olm encryption ensures you can't spoof the deviceid). - implement to_device messages arriving before m.call(.member) state event - reeable crypto & implement fetching olm keys before sending encrypted signalling message