From 8aa62b257326cdf94ac0c168d83174cfa169b06c Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Sun, 25 Sep 2022 21:39:38 +0100 Subject: [PATCH 1/2] don't ignore end-of-ICE candidates --- src/matrix/calls/PeerCall.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/matrix/calls/PeerCall.ts b/src/matrix/calls/PeerCall.ts index d004dedc..9a67fae1 100644 --- a/src/matrix/calls/PeerCall.ts +++ b/src/matrix/calls/PeerCall.ts @@ -818,14 +818,16 @@ export class PeerCall implements IDisposable { private async addIceCandidates(candidates: RTCIceCandidate[], log: ILogItem): Promise { for (const candidate of candidates) { + let logItem; if ( (candidate.sdpMid === null || candidate.sdpMid === undefined) && (candidate.sdpMLineIndex === null || candidate.sdpMLineIndex === undefined) ) { - log.log(`Ignoring remote ICE candidate with no sdpMid or sdpMLineIndex`); - continue; + logItem = log.log(`Got remote ICE end-of-ICE candidates`); + } + else { + logItem = log.log(`Adding remote ICE ${candidate.sdpMid} candidate: ${candidate.candidate}`); } - const logItem = log.log(`Adding remote ICE ${candidate.sdpMid} candidate: ${candidate.candidate}`); try { await this.peerConnection.addIceCandidate(candidate); } catch (err) { From 31e67142bdc1ffa2d503c7492371a703a26e07b2 Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Sun, 25 Sep 2022 22:11:35 +0100 Subject: [PATCH 2/2] typo --- src/matrix/calls/PeerCall.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/matrix/calls/PeerCall.ts b/src/matrix/calls/PeerCall.ts index 9a67fae1..1ee945c5 100644 --- a/src/matrix/calls/PeerCall.ts +++ b/src/matrix/calls/PeerCall.ts @@ -823,7 +823,7 @@ export class PeerCall implements IDisposable { (candidate.sdpMid === null || candidate.sdpMid === undefined) && (candidate.sdpMLineIndex === null || candidate.sdpMLineIndex === undefined) ) { - logItem = log.log(`Got remote ICE end-of-ICE candidates`); + logItem = log.log(`Got remote end-of-ICE candidates`); } else { logItem = log.log(`Adding remote ICE ${candidate.sdpMid} candidate: ${candidate.candidate}`);