add TODO comment

This commit is contained in:
Bruno Windels 2020-05-26 10:31:23 +02:00
parent 464615ab21
commit 9712b397ce

View File

@ -152,6 +152,10 @@ export class SessionContainer {
// restored the connection, it would have already // restored the connection, it would have already
// started to session, so check first // started to session, so check first
// to prevent an extra /versions request // to prevent an extra /versions request
// TODO: this doesn't look logical, but works. Why?
// I think because isStarted is true by default. That's probably not what we intend.
// I think there is a bug here, in that even if the reconnector already started the session, we'd still do this.
if (this._session.isStarted) { if (this._session.isStarted) {
const lastVersionsResponse = await hsApi.versions({timeout: 10000}).response(); const lastVersionsResponse = await hsApi.versions({timeout: 10000}).response();
this._session.start(lastVersionsResponse); this._session.start(lastVersionsResponse);