mirrors/vector-im-hydrogen-web
1
0
Fork 0
mirror of https://github.com/vector-im/hydrogen-web.git synced 2024-12-22 19:14:52 +01:00
Code Issues Projects Releases Wiki Activity

notes on codestyle

Browse Source
This commit is contained in:
Bruno Windels 2020-11-20 16:39:16 +01:00
parent 908a119dc9
commit 669865f8db
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
codestyle.md
View File

@ -3,6 +3,8 @@
- methods that return a promise should always use async/await - methods that return a promise should always use async/await
otherwise synchronous errors can get swallowed otherwise synchronous errors can get swallowed
you can return a promise without awaiting it though.
- only named exports, no default exports - only named exports, no default exports
otherwise it becomes hard to remember what was a default/named export otherwise it becomes hard to remember what was a default/named export
- should we return promises from storage mutation calls? probably not, as we don't await them anywhere. only read calls should return promises? - should we return promises from storage mutation calls? probably not, as we don't await them anywhere. only read calls should return promises?
- we don't anymore