From 41ebf13156380054365714f600bdabd72032580e Mon Sep 17 00:00:00 2001
From: RMidhunSuresh <hi@midhun.dev>
Date: Mon, 27 Mar 2023 16:36:27 +0530
Subject: [PATCH] Some more changes

---
 .../stages/SelectMethodViewModel.ts           |  4 ++++
 .../stages/VerificationCancelledViewModel.ts  |  4 ++++
 .../stages/VerificationCompleteViewModel.ts   |  4 ++++
 .../stages/VerifyEmojisViewModel.ts           |  4 ++++
 .../stages/WaitingForOtherUserViewModel.ts    |  4 ++++
 .../verification/DeviceVerificationView.ts    | 20 ++++++++-----------
 .../verification/stages/SelectMethodView.ts   |  4 ++--
 .../stages/VerificationCancelledView.ts       |  7 ++-----
 .../stages/VerificationCompleteView.ts        |  4 ++--
 .../verification/stages/VerifyEmojisView.ts   |  4 ++--
 .../stages/WaitingForOtherUserView.ts         |  4 ++--
 11 files changed, 38 insertions(+), 25 deletions(-)

diff --git a/src/domain/session/verification/stages/SelectMethodViewModel.ts b/src/domain/session/verification/stages/SelectMethodViewModel.ts
index 681a2e46..e88d0f83 100644
--- a/src/domain/session/verification/stages/SelectMethodViewModel.ts
+++ b/src/domain/session/verification/stages/SelectMethodViewModel.ts
@@ -47,4 +47,8 @@ export class SelectMethodViewModel extends ErrorReportViewModel<SegmentType, Opt
     get deviceName() {
         return this.options.stage.otherDeviceName;
     }
+
+    get kind(): string {
+        return "select-method";
+    }
 }
diff --git a/src/domain/session/verification/stages/VerificationCancelledViewModel.ts b/src/domain/session/verification/stages/VerificationCancelledViewModel.ts
index 01f11768..9e4d3e91 100644
--- a/src/domain/session/verification/stages/VerificationCancelledViewModel.ts
+++ b/src/domain/session/verification/stages/VerificationCancelledViewModel.ts
@@ -35,4 +35,8 @@ export class VerificationCancelledViewModel extends ViewModel<SegmentType, Optio
     gotoSettings() {
         this.navigation.push("settings", true);
     }
+
+    get kind(): string {
+        return "verification-cancelled";
+    }
 }
diff --git a/src/domain/session/verification/stages/VerificationCompleteViewModel.ts b/src/domain/session/verification/stages/VerificationCompleteViewModel.ts
index a6982eb9..c7ffd820 100644
--- a/src/domain/session/verification/stages/VerificationCompleteViewModel.ts
+++ b/src/domain/session/verification/stages/VerificationCompleteViewModel.ts
@@ -32,4 +32,8 @@ export class VerificationCompleteViewModel extends ErrorReportViewModel<SegmentT
     gotoSettings() {
         this.navigation.push("settings", true);
     }
+
+    get kind(): string {
+        return "verification-completed";
+    }
 }
diff --git a/src/domain/session/verification/stages/VerifyEmojisViewModel.ts b/src/domain/session/verification/stages/VerifyEmojisViewModel.ts
index 14868176..9f6dc92b 100644
--- a/src/domain/session/verification/stages/VerifyEmojisViewModel.ts
+++ b/src/domain/session/verification/stages/VerifyEmojisViewModel.ts
@@ -39,4 +39,8 @@ export class VerifyEmojisViewModel extends ErrorReportViewModel<SegmentType, Opt
     get emojis() {
         return this.options.stage.emoji;
     }
+
+    get kind(): string {
+        return "verify-emojis";
+    }
 }
diff --git a/src/domain/session/verification/stages/WaitingForOtherUserViewModel.ts b/src/domain/session/verification/stages/WaitingForOtherUserViewModel.ts
index 408ef884..ca68c941 100644
--- a/src/domain/session/verification/stages/WaitingForOtherUserViewModel.ts
+++ b/src/domain/session/verification/stages/WaitingForOtherUserViewModel.ts
@@ -26,4 +26,8 @@ export class WaitingForOtherUserViewModel extends ViewModel<SegmentType, Options
     async cancel() {
         await this.options.sas.abort();
     }
+
+    get kind(): string {
+        return "waiting-for-user";
+    }
 }
diff --git a/src/platform/web/ui/session/verification/DeviceVerificationView.ts b/src/platform/web/ui/session/verification/DeviceVerificationView.ts
index ed599031..93672b89 100644
--- a/src/platform/web/ui/session/verification/DeviceVerificationView.ts
+++ b/src/platform/web/ui/session/verification/DeviceVerificationView.ts
@@ -14,21 +14,16 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import {TemplateView} from "../../general/TemplateView";
-import {WaitingForOtherUserViewModel} from "../../../../../domain/session/verification/stages/WaitingForOtherUserViewModel";
+import {Builder, TemplateView} from "../../general/TemplateView";
 import {DeviceVerificationViewModel} from "../../../../../domain/session/verification/DeviceVerificationViewModel";
-import {VerificationCancelledViewModel} from "../../../../../domain/session/verification/stages/VerificationCancelledViewModel";
 import {WaitingForOtherUserView} from "./stages/WaitingForOtherUserView";
 import {VerificationCancelledView} from "./stages/VerificationCancelledView";
-import {SelectMethodViewModel} from "../../../../../domain/session/verification/stages/SelectMethodViewModel";
 import {SelectMethodView} from "./stages/SelectMethodView";
-import {VerifyEmojisViewModel} from "../../../../../domain/session/verification/stages/VerifyEmojisViewModel";
 import {VerifyEmojisView} from "./stages/VerifyEmojisView";
-import {VerificationCompleteViewModel} from "../../../../../domain/session/verification/stages/VerificationCompleteViewModel";
 import {VerificationCompleteView} from "./stages/VerificationCompleteView";
 
 export class DeviceVerificationView extends TemplateView<DeviceVerificationViewModel> {
-    render(t, vm) {
+    render(t: Builder<DeviceVerificationViewModel>) {
         return t.div({
             className: {
                 "middle": true,
@@ -36,21 +31,22 @@ export class DeviceVerificationView extends TemplateView<DeviceVerificationViewM
             }
         }, [
             t.mapView(vm => vm.currentStageViewModel, (stageVm) => {
-                if (stageVm instanceof WaitingForOtherUserViewModel) {
+                if (stageVm.kind === "waiting-for-user") {
                     return new WaitingForOtherUserView(stageVm);
                 }
-                else if (stageVm instanceof VerificationCancelledViewModel) {
+                else if (stageVm.kind === "verification-cancelled") {
                     return new VerificationCancelledView(stageVm);
                 }
-                else if (stageVm instanceof SelectMethodViewModel) {
+                else if (stageVm.kind === "select-method") {
                     return new SelectMethodView(stageVm);
                 }
-                else if (stageVm instanceof VerifyEmojisViewModel) {
+                else if (stageVm.kind === "verify-emojis") {
                     return new VerifyEmojisView(stageVm);
                 }
-                else if (stageVm instanceof VerificationCompleteViewModel) {
+                else if (stageVm.kind === "verification-completed") {
                     return new VerificationCompleteView(stageVm);
                 }
+                return null;
             })
         ])
     }
diff --git a/src/platform/web/ui/session/verification/stages/SelectMethodView.ts b/src/platform/web/ui/session/verification/stages/SelectMethodView.ts
index 9e665f31..e7603700 100644
--- a/src/platform/web/ui/session/verification/stages/SelectMethodView.ts
+++ b/src/platform/web/ui/session/verification/stages/SelectMethodView.ts
@@ -14,12 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import {TemplateView} from "../../../general/TemplateView";
+import {Builder, TemplateView} from "../../../general/TemplateView";
 import {spinner} from "../../../common.js"
 import type {SelectMethodViewModel} from "../../../../../../domain/session/verification/stages/SelectMethodViewModel";
 
 export class SelectMethodView extends TemplateView<SelectMethodViewModel> {
-    render(t) {
+    render(t: Builder<SelectMethodViewModel>) {
         return t.div({ className: "SelectMethodView" }, [
             t.map(vm => vm.hasProceeded, (hasProceeded, t, vm) => {
                 if (hasProceeded) {
diff --git a/src/platform/web/ui/session/verification/stages/VerificationCancelledView.ts b/src/platform/web/ui/session/verification/stages/VerificationCancelledView.ts
index 28cebf80..d2832ddb 100644
--- a/src/platform/web/ui/session/verification/stages/VerificationCancelledView.ts
+++ b/src/platform/web/ui/session/verification/stages/VerificationCancelledView.ts
@@ -14,12 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import {TemplateView} from "../../../general/TemplateView";
+import {Builder, TemplateView} from "../../../general/TemplateView";
 import {VerificationCancelledViewModel} from "../../../../../../domain/session/verification/stages/VerificationCancelledViewModel";
 import {CancelReason} from "../../../../../../matrix/verification/SAS/channel/types";
 
 export class VerificationCancelledView extends TemplateView<VerificationCancelledViewModel> {
-    render(t, vm: VerificationCancelledViewModel) {
+    render(t: Builder<VerificationCancelledViewModel>, vm: VerificationCancelledViewModel) {
         const headerTextStart = vm.isCancelledByUs ? "You" : "The other device";
 
         return t.div(
@@ -50,10 +50,8 @@ export class VerificationCancelledView extends TemplateView<VerificationCancelle
 
     getDescriptionFromCancellationCode(code: CancelReason, isCancelledByUs: boolean): string {
         const descriptionsWhenWeCancelled = {
-            // [CancelReason.UserCancelled]: NO_NEED_FOR_DESCRIPTION_HERE
             [CancelReason.InvalidMessage]: "You other device sent an invalid message.",
             [CancelReason.KeyMismatch]: "The key could not be verified.",
-            // [CancelReason.OtherDeviceAccepted]: "Another device has accepted this request.",
             [CancelReason.TimedOut]: "The verification process timed out.",
             [CancelReason.UnexpectedMessage]: "Your other device sent an unexpected message.",
             [CancelReason.UnknownMethod]: "Your other device is using an unknown method for verification.",
@@ -66,7 +64,6 @@ export class VerificationCancelledView extends TemplateView<VerificationCancelle
             [CancelReason.UserCancelled]: "Your other device cancelled the verification!",
             [CancelReason.InvalidMessage]: "Invalid message sent to the other device.",
             [CancelReason.KeyMismatch]: "The other device could not verify our keys",
-            // [CancelReason.OtherDeviceAccepted]: "Another device has accepted this request.",
             [CancelReason.TimedOut]: "The verification process timed out.",
             [CancelReason.UnexpectedMessage]: "Unexpected message sent to the other device.",
             [CancelReason.UnknownMethod]: "Your other device does not understand the method you chose",
diff --git a/src/platform/web/ui/session/verification/stages/VerificationCompleteView.ts b/src/platform/web/ui/session/verification/stages/VerificationCompleteView.ts
index 7edc4e40..26f6f326 100644
--- a/src/platform/web/ui/session/verification/stages/VerificationCompleteView.ts
+++ b/src/platform/web/ui/session/verification/stages/VerificationCompleteView.ts
@@ -14,11 +14,11 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import {TemplateView} from "../../../general/TemplateView";
+import {Builder, TemplateView} from "../../../general/TemplateView";
 import type {VerificationCompleteViewModel} from "../../../../../../domain/session/verification/stages/VerificationCompleteViewModel";
 
 export class VerificationCompleteView extends TemplateView<VerificationCompleteViewModel> {
-    render(t, vm: VerificationCompleteViewModel) {
+    render(t: Builder<VerificationCompleteViewModel>, vm: VerificationCompleteViewModel) {
         return t.div({ className: "VerificationCompleteView" }, [
             t.div({className: "VerificationCompleteView__icon"}),
             t.div({ className: "VerificationCompleteView__heading" }, [
diff --git a/src/platform/web/ui/session/verification/stages/VerifyEmojisView.ts b/src/platform/web/ui/session/verification/stages/VerifyEmojisView.ts
index 9f7b312b..32aba691 100644
--- a/src/platform/web/ui/session/verification/stages/VerifyEmojisView.ts
+++ b/src/platform/web/ui/session/verification/stages/VerifyEmojisView.ts
@@ -14,12 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import {TemplateView} from "../../../general/TemplateView";
+import {Builder, TemplateView} from "../../../general/TemplateView";
 import {spinner} from "../../../common.js"
 import type {VerifyEmojisViewModel} from "../../../../../../domain/session/verification/stages/VerifyEmojisViewModel";
 
 export class VerifyEmojisView extends TemplateView<VerifyEmojisViewModel> {
-    render(t, vm: VerifyEmojisViewModel) {
+    render(t: Builder<VerifyEmojisViewModel>, vm: VerifyEmojisViewModel) {
         const emojiList = vm.emojis.reduce((acc, [emoji, name]) => {
             const e = t.div({ className: "EmojiContainer" }, [
                 t.div({ className: "EmojiContainer__emoji" }, emoji),
diff --git a/src/platform/web/ui/session/verification/stages/WaitingForOtherUserView.ts b/src/platform/web/ui/session/verification/stages/WaitingForOtherUserView.ts
index 007b258e..0018a4b3 100644
--- a/src/platform/web/ui/session/verification/stages/WaitingForOtherUserView.ts
+++ b/src/platform/web/ui/session/verification/stages/WaitingForOtherUserView.ts
@@ -14,12 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import {TemplateView} from "../../../general/TemplateView";
+import {Builder, TemplateView} from "../../../general/TemplateView";
 import {spinner} from "../../../common.js";
 import {WaitingForOtherUserViewModel} from "../../../../../../domain/session/verification/stages/WaitingForOtherUserViewModel";
 
 export class WaitingForOtherUserView extends TemplateView<WaitingForOtherUserViewModel> {
-    render(t, vm) {
+    render(t: Builder<WaitingForOtherUserViewModel>, vm: WaitingForOtherUserViewModel) {
         return t.div({ className: "WaitingForOtherUserView" }, [
             t.div({ className: "WaitingForOtherUserView__heading" }, [
                 spinner(t),