From 414280ada9f28fcbc739243abfb5a145a1e0d4a3 Mon Sep 17 00:00:00 2001
From: Danila Fedorin <danila.fedorin@gmail.com>
Date: Wed, 29 Sep 2021 18:05:30 -0700
Subject: [PATCH] Add type annotations to BaseObservableList

---
 src/observable/list/BaseObservableList.ts | 27 +++++++++++++----------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/src/observable/list/BaseObservableList.ts b/src/observable/list/BaseObservableList.ts
index e2d8c3d5..9ba6559a 100644
--- a/src/observable/list/BaseObservableList.ts
+++ b/src/observable/list/BaseObservableList.ts
@@ -16,7 +16,15 @@ limitations under the License.
 
 import {BaseObservable} from "../BaseObservable";
 
-export class BaseObservableList extends BaseObservable {
+export interface IListObserver<T> {
+    onReset(list: BaseObservableList<T>): void;
+    onAdd(index: number, value:T, list: BaseObservableList<T>): void;
+    onUpdate(index: number, value: T, params: any, list: BaseObservableList<T>): void;
+    onRemove(index: number, value: T, list: BaseObservableList<T>): void
+    onMove(from: number, to: number, value: T, list: BaseObservableList<T>): void
+}
+
+export abstract class BaseObservableList<T> extends BaseObservable<IListObserver<T>> {
     emitReset() {
         for(let h of this._handlers) {
             h.onReset(this);
@@ -24,19 +32,19 @@ export class BaseObservableList extends BaseObservable {
     }
     // we need batch events, mostly on index based collection though?
     // maybe we should get started without?
-    emitAdd(index, value) {
+    emitAdd(index: number, value: T): void {
         for(let h of this._handlers) {
             h.onAdd(index, value, this);
         }
     }
 
-    emitUpdate(index, value, params) {
+    emitUpdate(index: number, value: T, params: any): void {
         for(let h of this._handlers) {
             h.onUpdate(index, value, params, this);
         }
     }
 
-    emitRemove(index, value) {
+    emitRemove(index: number, value: T): void {
         for(let h of this._handlers) {
             h.onRemove(index, value, this);
         }
@@ -44,17 +52,12 @@ export class BaseObservableList extends BaseObservable {
 
     // toIdx assumes the item has already
     // been removed from its fromIdx
-    emitMove(fromIdx, toIdx, value) {
+    emitMove(fromIdx: number, toIdx: number, value: T): void {
         for(let h of this._handlers) {
             h.onMove(fromIdx, toIdx, value, this);
         }
     }
 
-    [Symbol.iterator]() {
-        throw new Error("unimplemented");
-    }
-
-    get length() {
-        throw new Error("unimplemented");
-    }
+    abstract [Symbol.iterator](): IterableIterator<T>;
+    abstract get length(): number;
 }