mirrors/vector-im-hydrogen-web
1
0
Fork 0
mirror of https://github.com/vector-im/hydrogen-web.git synced 2024-12-24 03:55:09 +01:00
Code Issues Projects Releases Wiki Activity

fix the race

Browse Source
This commit is contained in:
Bruno Windels 2021-06-02 18:42:46 +02:00
parent 84ecaa2ee1
commit 365bd5cad0
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/matrix/room/timeline/Timeline.js
View File

@ -145,6 +145,17 @@ export class Timeline {
} }
_addLocalRelationsToNewRemoteEntries(entries) { _addLocalRelationsToNewRemoteEntries(entries) {
// because it is not safe to iterate a derived observable collection
// before it has any subscriptions, we bail out if this isn't
// the case yet. This can happen when sync adds or replaces entries
// before load has finished and the view has subscribed to the timeline.
//
// Once the subscription is setup, MappedList will set up the local
// relations as needed with _applyAndEmitLocalRelationChange,
// so we're not missing anything by bailing out.
if (!this._localEntries.hasSubscriptions) {
return;
}
// find any local relations to this new remote event // find any local relations to this new remote event
for (const pee of this._localEntries) { for (const pee of this._localEntries) {
// this will work because we set relatedEventId when removing remote echos // this will work because we set relatedEventId when removing remote echos