Updates comparator

src/observable/list/BaseObservableList.ts

@@ -31,7 +31,7 @@ export function defaultObserverWith<T>(overrides: { [key in keyof IListObserver<
         onUpdate(){},
         onRemove(){},
         onMove(){},
-    }
+    };
     return Object.assign(defaults, overrides);
 }
 

src/observable/list/SortedArray.ts

@@ -87,7 +87,7 @@ export class SortedArray<T> extends BaseObservableList<T> {
         const idx = sortedIndex(this._items, item, this._comparator);
         if (idx >= this._items.length || this._comparator(this._items[idx], item) !== 0) {
             this._items.splice(idx, 0, item);
-            this.emitAdd(idx, item)
+            this.emitAdd(idx, item);
         } else {
             this._items[idx] = item;
             this.emitUpdate(idx, item, updateParams);
@@ -156,7 +156,7 @@ export function tests() {
             assert.equal(sa.get(0), "a");
             assert.equal(sa.get(1), "b");
             assert.equal(sa.get(2), "c");
-        }, 
+        },
         "_getNext": assert => {
             const sa = new SortedArray<string>((a, b) => a.localeCompare(b));
             sa.setManyUnsorted(["b", "a", "f"]);
@@ -183,5 +183,5 @@ export function tests() {
             // check done persists
             assert.equal(it.next().done, true);
         }
-    }
+    };
 }

src/observable/list/SortedMapList.js

@@ -129,7 +129,7 @@ export class SortedMapList extends BaseObservableList {
                 }
                 return v;
             }
-        }
+        };
     }
 }
 
@@ -267,5 +267,5 @@ export function tests() {
             assert.equal(updateFired, 1);
             assert.deepEqual(Array.from(list).map(v => v.number), [1, 3, 11]);
         },
-    }
+    };
 }

src/observable/map/ApplyMap.ts

@@ -44,7 +44,7 @@ export class ApplyMap<K, V> extends BaseObservableMap<K, V> {
         return this._config.mapValues(this, mapper, updater);
     }
 
-    sortValues(comparator?: (a: any, b: any) => number): SortedMapList {
+    sortValues(comparator: (a: V, b: V) => number): SortedMapList {
         return this._config.sortValues(this, comparator);
     }
 

src/observable/map/BaseObservableMap.ts

@@ -30,7 +30,7 @@ export interface IMapObserver<K, V> {
 export type BaseObservableMapConfig<K, V> = {
     join(_this: BaseObservableMap<K, V>, ...otherMaps: Array<BaseObservableMap<K, V>>): JoinedMap<K, V>;
     mapValues(_this: BaseObservableMap<K, V>, mapper: any, updater?: (params: any) => void): MappedMap<K, V>;
-    sortValues(_this: BaseObservableMap<K, V>, comparator?: (a: any, b: any) => number): SortedMapList;
+    sortValues(_this: BaseObservableMap<K, V>, comparator: (a: V, b: V) => number): SortedMapList;
     filterValues(_this: BaseObservableMap<K, V>, filter: (v: V, k: K) => boolean): FilteredMap<K, V>;
 }
 
@@ -68,7 +68,7 @@ export abstract class BaseObservableMap<K, V> extends BaseObservable<IMapObserve
     // this one (which is most likely what you want to do).
     abstract join(...otherMaps: Array<typeof this>): JoinedMap<K, V>;
     abstract mapValues(mapper: any, updater?: (params: any) => void): MappedMap<K, V>;
-    abstract sortValues(comparator?: (a: any, b: any) => number): SortedMapList;
+    abstract sortValues(comparator: (a: V, b: V) => number): SortedMapList;
     abstract filterValues(filter: (v: V, k: K) => boolean): FilteredMap<K, V>;
 
     abstract [Symbol.iterator](): Iterator<[K, V]>;

src/observable/map/FilteredMap.ts

@@ -43,7 +43,7 @@ export class FilteredMap<K, V> extends BaseObservableMap<K, V> {
         return this._config.mapValues(this, mapper, updater);
     }
 
-    sortValues(comparator?: (a: any, b: any) => number): SortedMapList {
+    sortValues(comparator: (a: V, b: V) => number): SortedMapList {
         return this._config.sortValues(this, comparator);
     }
 

src/observable/map/JoinedMap.ts

@@ -41,7 +41,7 @@ export class JoinedMap<K, V> extends BaseObservableMap<K, V> {
         return this._config.mapValues(this, mapper, updater);
     }
 
-    sortValues(comparator?: (a: any, b: any) => number): SortedMapList {
+    sortValues(comparator: (a: V, b: V) => number): SortedMapList {
         return this._config.sortValues(this, comparator);
     }
 

src/observable/map/LogMap.ts

@@ -20,7 +20,7 @@ import {FilteredMap} from "./FilteredMap.js";
 import {MappedMap} from "./MappedMap.js";
 import {JoinedMap} from "./JoinedMap.js";
 import {SortedMapList} from "../list/SortedMapList.js";
-import {SubscriptionHandle} from "../BaseObservable"
+import {SubscriptionHandle} from "../BaseObservable";
 import {ILogItem, LabelOrValues} from "../../logging/types";
 import {LogLevel} from "../../logging/LogFilter";
 
@@ -46,7 +46,7 @@ export class LogMap<K, V> extends BaseObservableMap<K, V> {
         return this._config.mapValues(this, mapper, updater);
     }
 
-    sortValues(comparator?: (a: any, b: any) => number): SortedMapList {
+    sortValues(comparator: (a: V, b: V) => number): SortedMapList {
         return this._config.sortValues(this, comparator);
     }
 

src/observable/map/MappedMap.ts

@@ -54,7 +54,7 @@ export class MappedMap<K, V> extends BaseObservableMap<K, V> {
         return this._config.mapValues(this, mapper, updater);
     }
 
-    sortValues(comparator?: (a: any, b: any) => number): SortedMapList {
+    sortValues(comparator: (a: V, b: V) => number): SortedMapList {
         return this._config.sortValues(this, comparator);
     }
 

src/observable/map/ObservableMap.ts

@@ -40,7 +40,7 @@ export class ObservableMap<K, V> extends BaseObservableMap<K, V> {
         return this._config.mapValues(this, mapper, updater);
     }
 
-    sortValues(comparator?: (a: any, b: any) => number): SortedMapList {
+    sortValues(comparator: (a: V, b: V) => number): SortedMapList {
         return this._config.sortValues(this, comparator);
     }
 
@@ -249,5 +249,5 @@ export function tests() {
             map.add(2, {number: 6});
             assert.equal(map.size, 2);
         },
-    }
+    };
 }

src/observable/map/config.ts

@@ -33,7 +33,7 @@ export function config<K, V>(): BaseObservableMapConfig<K, V> {
         mapValues: (_this: BaseObservableMap<K, V>, mapper: any, updater: (params: any) => void): MappedMap<K, V> => {
             return new MappedMap(_this, mapper, updater);
         },
-        sortValues: (_this: BaseObservableMap<K, V>, comparator?: (a: any, b: any) => number): SortedMapList => {
+        sortValues: (_this: BaseObservableMap<K, V>, comparator: (a: V, b: V) => number): SortedMapList => {
             return new SortedMapList(_this, comparator);
         },
         filterValues: (_this: BaseObservableMap<K, V>, filter: (v: V, k: K) => boolean): FilteredMap<K, V> => {