mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-15 07:34:58 +01:00
cbd0ee1d07
* Update devise-two-factor to unreleased fork for Rails 6 support Update tests to match new `rotp` version. * Update nsa gem to unreleased fork for Rails 6 support * Update rails to 6.1.3 and rails-i18n to 6.0 * Update to unreleased fork of pluck_each for Ruby 6 support * Run "rails app:update" * Add missing ActiveStorage config file * Use config.ssl_options instead of removed ApplicationController#force_ssl Disabled force_ssl-related tests as they do not seem to be easily testable anymore. * Fix nonce directives by removing Rails 5 specific monkey-patching * Fix fixture_file_upload deprecation warning * Fix yield-based test failing with Rails 6 * Use Rails 6's index_with when possible * Use ActiveRecord::Cache::Store#delete_multi from Rails 6 This will yield better performances when deleting an account * Disable Rails 6.1's automatic preload link headers Since Rails 6.1, ActionView adds preload links for javascript files in the Links header per default. In our case, that will bloat headers too much and potentially cause issues with reverse proxies. Furhermore, we don't need those links, as we already output them as HTML link tags. * Switch to Rails 6.0 default config * Switch to Rails 6.1 default config * Do not include autoload paths in the load path
132 lines
4.0 KiB
Ruby
132 lines
4.0 KiB
Ruby
require 'rails_helper'
|
|
|
|
RSpec.describe Api::V1::MediaController, type: :controller do
|
|
render_views
|
|
|
|
let(:user) { Fabricate(:user, account: Fabricate(:account, username: 'alice')) }
|
|
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: 'write:media') }
|
|
|
|
before do
|
|
allow(controller).to receive(:doorkeeper_token) { token }
|
|
end
|
|
|
|
describe 'POST #create' do
|
|
describe 'with paperclip errors' do
|
|
context 'when imagemagick cant identify the file type' do
|
|
before do
|
|
expect_any_instance_of(Account).to receive_message_chain(:media_attachments, :create!).and_raise(Paperclip::Errors::NotIdentifiedByImageMagickError)
|
|
post :create, params: { file: fixture_file_upload('attachment.jpg', 'image/jpeg') }
|
|
end
|
|
|
|
it 'returns http 422' do
|
|
expect(response).to have_http_status(:unprocessable_entity)
|
|
end
|
|
end
|
|
|
|
context 'when there is a generic error' do
|
|
before do
|
|
expect_any_instance_of(Account).to receive_message_chain(:media_attachments, :create!).and_raise(Paperclip::Error)
|
|
post :create, params: { file: fixture_file_upload('attachment.jpg', 'image/jpeg') }
|
|
end
|
|
|
|
it 'returns http 422' do
|
|
expect(response).to have_http_status(500)
|
|
end
|
|
end
|
|
end
|
|
|
|
context 'image/jpeg' do
|
|
before do
|
|
post :create, params: { file: fixture_file_upload('attachment.jpg', 'image/jpeg') }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'creates a media attachment' do
|
|
expect(MediaAttachment.first).to_not be_nil
|
|
end
|
|
|
|
it 'uploads a file' do
|
|
expect(MediaAttachment.first).to have_attached_file(:file)
|
|
end
|
|
|
|
it 'returns media ID in JSON' do
|
|
expect(body_as_json[:id]).to eq MediaAttachment.first.id.to_s
|
|
end
|
|
end
|
|
|
|
context 'image/gif' do
|
|
before do
|
|
post :create, params: { file: fixture_file_upload('attachment.gif', 'image/gif') }
|
|
end
|
|
|
|
it 'returns http success' do
|
|
expect(response).to have_http_status(200)
|
|
end
|
|
|
|
it 'creates a media attachment' do
|
|
expect(MediaAttachment.first).to_not be_nil
|
|
end
|
|
|
|
it 'uploads a file' do
|
|
expect(MediaAttachment.first).to have_attached_file(:file)
|
|
end
|
|
|
|
it 'returns media ID in JSON' do
|
|
expect(body_as_json[:id]).to eq MediaAttachment.first.id.to_s
|
|
end
|
|
end
|
|
|
|
context 'video/webm' do
|
|
before do
|
|
post :create, params: { file: fixture_file_upload('attachment.webm', 'video/webm') }
|
|
end
|
|
|
|
it do
|
|
# returns http success
|
|
expect(response).to have_http_status(200)
|
|
|
|
# creates a media attachment
|
|
expect(MediaAttachment.first).to_not be_nil
|
|
|
|
# uploads a file
|
|
expect(MediaAttachment.first).to have_attached_file(:file)
|
|
|
|
# returns media ID in JSON
|
|
expect(body_as_json[:id]).to eq MediaAttachment.first.id.to_s
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'PUT #update' do
|
|
context 'when somebody else\'s' do
|
|
let(:media) { Fabricate(:media_attachment, status: nil) }
|
|
|
|
it 'returns http not found' do
|
|
put :update, params: { id: media.id, description: 'Lorem ipsum!!!' }
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
|
|
context 'when not attached to a status' do
|
|
let(:media) { Fabricate(:media_attachment, status: nil, account: user.account) }
|
|
|
|
it 'updates the description' do
|
|
put :update, params: { id: media.id, description: 'Lorem ipsum!!!' }
|
|
expect(media.reload.description).to eq 'Lorem ipsum!!!'
|
|
end
|
|
end
|
|
|
|
context 'when attached to a status' do
|
|
let(:media) { Fabricate(:media_attachment, status: Fabricate(:status), account: user.account) }
|
|
|
|
it 'returns http not found' do
|
|
put :update, params: { id: media.id, description: 'Lorem ipsum!!!' }
|
|
expect(response).to have_http_status(:not_found)
|
|
end
|
|
end
|
|
end
|
|
end
|