mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-05 02:36:29 +01:00
d14e74eff5
* add youtube oembed endpoint * add check for oembed endpoint * change unless for a more readable if * clear blank lines * endpoint via https * Fix string literal in condition * use cache for endpoints * use cache for endpoints * clean up and adding check * clean up and remove redundant return * add html check * add false to return * use double quotes * use double quotes * Clean up
162 lines
5.8 KiB
Ruby
162 lines
5.8 KiB
Ruby
# frozen_string_literal: true
|
|
|
|
require 'rails_helper'
|
|
|
|
describe FetchOEmbedService, type: :service do
|
|
subject { described_class.new }
|
|
|
|
before do
|
|
stub_request(:get, "https://host.test/provider.json").to_return(status: 404)
|
|
stub_request(:get, "https://host.test/provider.xml").to_return(status: 404)
|
|
stub_request(:get, "https://host.test/empty_provider.json").to_return(status: 200)
|
|
end
|
|
|
|
describe 'discover_provider' do
|
|
context 'when status code is 200 and MIME type is text/html' do
|
|
context 'Both of JSON and XML provider are discoverable' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider if :format option is set to :json' do
|
|
subject.call('https://host.test/oembed.html', format: :json)
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
|
|
expect(subject.format).to eq :json
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for XML provider if :format option is set to :xml' do
|
|
subject.call('https://host.test/oembed.html', format: :xml)
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
|
|
expect(subject.format).to eq :xml
|
|
end
|
|
end
|
|
|
|
context 'JSON provider is discoverable while XML provider is not' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.json'
|
|
expect(subject.format).to eq :json
|
|
end
|
|
end
|
|
|
|
context 'XML provider is discoverable while JSON provider is not' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for XML provider' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(subject.endpoint_url).to eq 'https://host.test/provider.xml'
|
|
expect(subject.format).to eq :xml
|
|
end
|
|
end
|
|
|
|
context 'Invalid XML provider is discoverable while JSON provider is not' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_invalid_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'Neither of JSON and XML provider is discoverable' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_undiscoverable.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'Empty JSON provider is discoverable' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json_empty.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new OEmbed::Provider for JSON provider' do
|
|
subject.call('https://host.test/oembed.html')
|
|
expect(subject.endpoint_url).to eq 'https://host.test/empty_provider.json'
|
|
expect(subject.format).to eq :json
|
|
end
|
|
end
|
|
|
|
end
|
|
|
|
context 'when endpoint is cached' do
|
|
before do
|
|
stub_request(:get, 'http://www.youtube.com/oembed?format=json&url=https://www.youtube.com/watch?v=dqwpQarrDwk').to_return(
|
|
status: 200,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_json_empty.html')
|
|
)
|
|
end
|
|
|
|
it 'returns new provider without fetching original URL first' do
|
|
subject.call('https://www.youtube.com/watch?v=dqwpQarrDwk', cached_endpoint: { endpoint: 'http://www.youtube.com/oembed?format=json&url={url}', format: :json })
|
|
expect(a_request(:get, 'https://www.youtube.com/watch?v=dqwpQarrDwk')).to_not have_been_made
|
|
expect(subject.endpoint_url).to eq 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk'
|
|
expect(subject.format).to eq :json
|
|
expect(a_request(:get, 'http://www.youtube.com/oembed?format=json&url=https%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3DdqwpQarrDwk')).to have_been_made
|
|
end
|
|
end
|
|
|
|
context 'when status code is not 200' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 400,
|
|
headers: { 'Content-Type': 'text/html' },
|
|
body: request_fixture('oembed_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
|
|
context 'when MIME type is not text/html' do
|
|
before do
|
|
stub_request(:get, 'https://host.test/oembed.html').to_return(
|
|
status: 200,
|
|
body: request_fixture('oembed_xml.html')
|
|
)
|
|
end
|
|
|
|
it 'returns nil' do
|
|
expect(subject.call('https://host.test/oembed.html')).to be_nil
|
|
end
|
|
end
|
|
end
|
|
end
|