mirror of
https://github.com/mastodon/mastodon.git
synced 2024-12-14 23:24:55 +01:00
e20895f251
* Add list of lists component to web UI * Add list adding * Add list removing * List editor modal * Add API account search limited by following=true relation * Rework list editor modal * Remove mandatory pagination of GET /api/v1/lists/:id/accounts * Adjust search input placeholder * Fix rspec (#5890) * i18n: (zh-CN) Add missing translations for #5811 (#5891) * i18n: (zh-CN) yarn manage:translations -- zh-CN * i18n: (zh-CN) Add missing translations for #5811 * Fix some issues - Display loading/missing state for list timelines - Order lists alphabetically in overview - Fix async list editor reset - Redirect to /lists after deleting unpinned list - Redirect to / after pinning a list * Remove dead list columns when a list is deleted or fetch returns 404
142 lines
4.6 KiB
Ruby
142 lines
4.6 KiB
Ruby
require 'rails_helper'
|
|
|
|
describe AccountSearchService do
|
|
describe '.call' do
|
|
describe 'with a query to ignore' do
|
|
it 'returns empty array for missing query' do
|
|
results = subject.call('', 10)
|
|
|
|
expect(results).to eq []
|
|
end
|
|
it 'returns empty array for hashtag query' do
|
|
results = subject.call('#tag', 10)
|
|
|
|
expect(results).to eq []
|
|
end
|
|
it 'returns empty array for limit zero' do
|
|
Fabricate(:account, username: 'match')
|
|
results = subject.call('match', 0)
|
|
|
|
expect(results).to eq []
|
|
end
|
|
end
|
|
|
|
describe 'searching for a simple term that is not an exact match' do
|
|
it 'does not return a nil entry in the array for the exact match' do
|
|
match = Fabricate(:account, username: 'matchingusername')
|
|
|
|
results = subject.call('match', 5)
|
|
expect(results).to eq [match]
|
|
end
|
|
end
|
|
|
|
describe 'searching local and remote users' do
|
|
describe "when only '@'" do
|
|
before do
|
|
allow(Account).to receive(:find_local)
|
|
allow(Account).to receive(:search_for)
|
|
subject.call('@', 10)
|
|
end
|
|
|
|
it 'uses find_local with empty query to look for local accounts' do
|
|
expect(Account).to have_received(:find_local).with('')
|
|
end
|
|
end
|
|
|
|
describe 'when no domain' do
|
|
before do
|
|
allow(Account).to receive(:find_local)
|
|
allow(Account).to receive(:search_for)
|
|
subject.call('one', 10)
|
|
end
|
|
|
|
it 'uses find_local to look for local accounts' do
|
|
expect(Account).to have_received(:find_local).with('one')
|
|
end
|
|
|
|
it 'uses search_for to find matches' do
|
|
expect(Account).to have_received(:search_for).with('one', 10)
|
|
end
|
|
end
|
|
|
|
describe 'when there is a domain' do
|
|
before do
|
|
allow(Account).to receive(:find_remote)
|
|
end
|
|
|
|
it 'uses find_remote to look for remote accounts' do
|
|
subject.call('two@example.com', 10)
|
|
expect(Account).to have_received(:find_remote).with('two', 'example.com')
|
|
end
|
|
|
|
describe 'and there is no account provided' do
|
|
it 'uses search_for to find matches' do
|
|
allow(Account).to receive(:search_for)
|
|
subject.call('two@example.com', 10, nil, resolve: false)
|
|
|
|
expect(Account).to have_received(:search_for).with('two example.com', 10)
|
|
end
|
|
end
|
|
|
|
describe 'and there is an account provided' do
|
|
it 'uses advanced_search_for to find matches' do
|
|
account = Fabricate(:account)
|
|
allow(Account).to receive(:advanced_search_for)
|
|
subject.call('two@example.com', 10, account, resolve: false)
|
|
|
|
expect(Account).to have_received(:advanced_search_for).with('two example.com', account, 10, nil)
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
describe 'with an exact match' do
|
|
it 'returns exact match first, and does not return duplicates' do
|
|
partial = Fabricate(:account, username: 'exactness')
|
|
exact = Fabricate(:account, username: 'exact')
|
|
|
|
results = subject.call('exact', 10)
|
|
expect(results.size).to eq 2
|
|
expect(results).to eq [exact, partial]
|
|
end
|
|
end
|
|
|
|
describe 'when there is a local domain' do
|
|
around do |example|
|
|
before = Rails.configuration.x.local_domain
|
|
example.run
|
|
Rails.configuration.x.local_domain = before
|
|
end
|
|
|
|
it 'returns exact match first' do
|
|
remote = Fabricate(:account, username: 'a', domain: 'remote', display_name: 'e')
|
|
remote_too = Fabricate(:account, username: 'b', domain: 'remote', display_name: 'e')
|
|
exact = Fabricate(:account, username: 'e')
|
|
Rails.configuration.x.local_domain = 'example.com'
|
|
|
|
results = subject.call('e@example.com', 2)
|
|
expect(results.size).to eq 2
|
|
expect(results).to eq([exact, remote]).or eq([exact, remote_too])
|
|
end
|
|
end
|
|
|
|
describe 'when there is a domain but no exact match' do
|
|
it 'follows the remote account when resolve is true' do
|
|
service = double(call: nil)
|
|
allow(ResolveRemoteAccountService).to receive(:new).and_return(service)
|
|
|
|
results = subject.call('newuser@remote.com', 10, nil, resolve: true)
|
|
expect(service).to have_received(:call).with('newuser@remote.com')
|
|
end
|
|
|
|
it 'does not follow the remote account when resolve is false' do
|
|
service = double(call: nil)
|
|
allow(ResolveRemoteAccountService).to receive(:new).and_return(service)
|
|
|
|
results = subject.call('newuser@remote.com', 10, nil, resolve: false)
|
|
expect(service).not_to have_received(:call)
|
|
end
|
|
end
|
|
end
|
|
end
|