From ec953bf378ac6ae9b7dab5db053dca947f3c869b Mon Sep 17 00:00:00 2001
From: Claire <claire.github-309c@sitedethib.com>
Date: Fri, 1 Mar 2024 11:16:35 +0100
Subject: [PATCH] Fix regression in handling `select` elements in
 `packs/admin.tsx` (#29469)

---
 app/javascript/packs/admin.tsx | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/app/javascript/packs/admin.tsx b/app/javascript/packs/admin.tsx
index 25e0889cd9..9fee560565 100644
--- a/app/javascript/packs/admin.tsx
+++ b/app/javascript/packs/admin.tsx
@@ -149,7 +149,7 @@ Rails.delegate(
   },
 );
 
-const onDomainBlockSeverityChange = (target: HTMLInputElement) => {
+const onDomainBlockSeverityChange = (target: HTMLSelectElement) => {
   const rejectMediaDiv = document.querySelector(
     '.input.with_label.domain_block_reject_media',
   );
@@ -169,7 +169,7 @@ const onDomainBlockSeverityChange = (target: HTMLInputElement) => {
 };
 
 Rails.delegate(document, '#domain_block_severity', 'change', ({ target }) => {
-  if (target instanceof HTMLInputElement) onDomainBlockSeverityChange(target);
+  if (target instanceof HTMLSelectElement) onDomainBlockSeverityChange(target);
 });
 
 const onEnableBootstrapTimelineAccountsChange = (target: HTMLInputElement) => {
@@ -206,7 +206,7 @@ Rails.delegate(
   },
 );
 
-const onChangeRegistrationMode = (target: HTMLInputElement) => {
+const onChangeRegistrationMode = (target: HTMLSelectElement) => {
   const enabled = target.value === 'approved';
 
   document
@@ -256,7 +256,7 @@ Rails.delegate(
   '#form_admin_settings_registrations_mode',
   'change',
   ({ target }) => {
-    if (target instanceof HTMLInputElement) onChangeRegistrationMode(target);
+    if (target instanceof HTMLSelectElement) onChangeRegistrationMode(target);
   },
 );
 
@@ -286,11 +286,11 @@ async function mountReactComponent(element: Element) {
 }
 
 ready(() => {
-  const domainBlockSeverityInput = document.querySelector<HTMLInputElement>(
-    'input#domain_block_severity',
+  const domainBlockSeveritySelect = document.querySelector<HTMLSelectElement>(
+    'select#domain_block_severity',
   );
-  if (domainBlockSeverityInput)
-    onDomainBlockSeverityChange(domainBlockSeverityInput);
+  if (domainBlockSeveritySelect)
+    onDomainBlockSeverityChange(domainBlockSeveritySelect);
 
   const enableBootstrapTimelineAccounts =
     document.querySelector<HTMLInputElement>(
@@ -299,8 +299,8 @@ ready(() => {
   if (enableBootstrapTimelineAccounts)
     onEnableBootstrapTimelineAccountsChange(enableBootstrapTimelineAccounts);
 
-  const registrationMode = document.querySelector<HTMLInputElement>(
-    'input#form_admin_settings_registrations_mode',
+  const registrationMode = document.querySelector<HTMLSelectElement>(
+    'select#form_admin_settings_registrations_mode',
   );
   if (registrationMode) onChangeRegistrationMode(registrationMode);