Use response.parsed_body for html response checks (#31750)

spec/controllers/admin/accounts_controller_spec.rb

@@ -48,7 +48,7 @@ RSpec.describe Admin::AccountsController do
     end
 
     def accounts_table_rows
-      Nokogiri::Slop(response.body).css('table.accounts-table tr')
+      response.parsed_body.css('table.accounts-table tr')
     end
   end
 

spec/controllers/admin/export_domain_blocks_controller_spec.rb

@@ -64,7 +64,7 @@ RSpec.describe Admin::ExportDomainBlocksController do
     end
 
     def batch_table_rows
-      Nokogiri::Slop(response.body).css('body div.batch-table__row')
+      response.parsed_body.css('body div.batch-table__row')
     end
   end
 

spec/controllers/admin/instances_controller_spec.rb

@@ -35,7 +35,7 @@ RSpec.describe Admin::InstancesController do
     end
 
     def instance_directory_links
-      Nokogiri::Slop(response.body).css('div.directory__tag a')
+      response.parsed_body.css('div.directory__tag a')
     end
   end
 

spec/controllers/auth/registrations_controller_spec.rb

@@ -342,7 +342,7 @@ RSpec.describe Auth::RegistrationsController do
       end
 
       def username_error_text
-        Nokogiri::Slop(response.body).css('.user_account_username .error').text
+        response.parsed_body.css('.user_account_username .error').text
       end
     end
 

spec/requests/account_show_page_spec.rb

@@ -18,14 +18,16 @@ RSpec.describe 'The account show page' do
   end
 
   def head_link_icons
-    head_section.css('link[rel=icon]')
+    response
+      .parsed_body
+      .search('html head link[rel=icon]')
   end
 
   def head_meta_content(property)
-    head_section.meta("[@property='#{property}']")[:content]
+    response
-  end
+      .parsed_body
-
+      .search("html head meta[property='#{property}']")
-  def head_section
+      .attr('content')
-    Nokogiri::Slop(response.body).html.head
+      .text
   end
 end