From 728ca82d79b194fa9186d9fe2c516922ff1b6775 Mon Sep 17 00:00:00 2001 From: taichi221228 Date: Thu, 2 May 2024 13:36:19 +0900 Subject: [PATCH] Added clarifying comment to emoji_utils.ts function A comment has been added to the 'getData' function in emoji_utils.ts to clarify that the source code version does not match that of DefinitelyTyped. The note also highlights the challenges in maintaining type consistency due to outdated and non-existing properties. --- app/javascript/mastodon/features/emoji/emoji_utils.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/javascript/mastodon/features/emoji/emoji_utils.ts b/app/javascript/mastodon/features/emoji/emoji_utils.ts index bf5605ebe7..2c56ad76fe 100644 --- a/app/javascript/mastodon/features/emoji/emoji_utils.ts +++ b/app/javascript/mastodon/features/emoji/emoji_utils.ts @@ -122,6 +122,10 @@ function getSanitizedData(...args: GetDataArgs) { } function getData(...[emoji, skin, set]: GetDataArgs) { + /* + The version of [the referenced source code]{@link https://github.com/missive/emoji-mart/blob/5f2ffcc/src/utils/index.js} does not match that of DefinitelyTyped. + It is also old, and non-existent properties have been added or removed, making it difficult to achieve type consistency. + */ /* eslint-disable @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call, @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-return */ /* eslint-disable-next-line @typescript-eslint/no-explicit-any */ let emojiData: any = {};